Repository navigation
Conversation
The 7-day row under each chore draws missed days as red crosses. A new per-device setting, 'Show missed days' in the widget's settings menu, hides them: with it off, a missed day draws as plain 'nothing logged' (the grey empty star), while done days still show their stars. The History dialog and the streak still see the real record; only the row's drawing changes. Defaults on, so nothing changes until the setting is flipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chores widget's 7-day row draws a missed day as a red cross. There was no way to hide just that mark without hiding the whole row (which also hides the done-day stars). This adds a per-display setting, "Show missed days", in the widget's settings menu.
With it off, a missed day draws as the plain "nothing logged" mark instead of the red cross, while done days still show their gold stars. The setting defaults on, so nothing changes until it is flipped. The History dialog and the streak still see the real record; only the row's drawing changes.
displayDayshelper inclient/src/utils/choreDays.js(missed -> open when the setting is off) with 4 new tests inchoreDays.test.jsChoreWidget.jsx: setting adopted and persisted with the other per-device settings, switch in the settings popover (disabled while the row itself is off), row render maps throughdisplayDayschores:history.showMissedMarks/showMissedMarksHelper/weekHeadingin en + es (check: es 2020/2020, 100%)Tests: client 98 files / 1068 tests pass, vite build passes; server 769 pass.
With the setting on:
With the setting off (same week — the gold star stays, the cross becomes a plain empty mark):
The new toggle in the settings menu:
Generated with Muse AI 🤖